search

charmplusplus / charm

The Charm++ parallel programming system. Visit https://charmplusplus.org/ for more information.
Apache License 2.0
203 stars 49 forks source link

Remove need for +LBCommOff #1492

Closed stwhite91 closed 2 years ago

stwhite91 commented 7 years ago

Original issue: https://charm.cs.illinois.edu/redmine/issues/1492

The LB Database should not collect comm info unless a balancer that is running actually uses it. For PDES and fine-grained communication intensive applications the overhead of lb comm info collection is huge.

kavithachandrasekar commented 5 years ago

Original date: 2017-04-13 20:44:32

I have added the ability for LB's to specify the commStatsOn, and have removed it from command line options. There are over 10 LBs that need this option, so I am adding the option from the LB's currently.

kavithachandrasekar commented 5 years ago

Original date: 2017-04-13 21:21:49

https://charm.cs.illinois.edu/gerrit/#/c/2396/

stwhite91 commented 5 years ago

Original date: 2017-05-17 22:45:28

Related: this patch allows '+LBCommOff' to avoid more of the overhead that comm stats collection entails: https://charm.cs.illinois.edu/gerrit/#/c/2533/ https://github.com/UIUC-PPL/charm/commit/60c6d4bb5a4cbee57cf770fe141f327c309a13c9

stwhite91 commented 5 years ago

Kavitha's patch has remaining unaddressed review comments that aren't likely to be fixed before 6.10's release. The new LB infrastructure should also not collect LB Comm stats when the LB strategy in use doesn't have any use for them.

stwhite91 commented 4 years ago

Is this still relevant given the new LB framework?

stwhite91 commented 4 years ago

^^^ Bump. @rbuch @kavithachandrasekar