search

charmplusplus / charm

The Charm++ parallel programming system. Visit https://charmplusplus.org/ for more information.
Apache License 2.0
206 stars 50 forks source link

Generate libmpi.{a,so} for AMPI configure scripts #1763

Open stwhite91 opened 6 years ago

stwhite91 commented 6 years ago

Original issue: https://charm.cs.illinois.edu/redmine/issues/1763

For increased compatibility with configure scripts, when we're not on an underlying MPI build, we can produce a libmpi.a/libmpi.so with the non-prefixed names (MPI_*) as the actual symbol names so that we don't need to hack around autoconf tests that don't include mpi.h but otherwise test MPI support.

stwhite91 commented 5 years ago

Original date: 2017-12-20 23:46:13

This gets us AMPI's MPI_* routines to not be renamed when building on non-MPI layers: https://charm.cs.illinois.edu/gerrit/#/c/3460/ https://github.com/UIUC-PPL/charm/commit/26085533ce2ad73c891783604856094943dc3712

matthiasdiener commented 5 years ago

Original date: 2018-01-13 19:18:14

Which application does that? Would it make sense to patch those manually (similar to what we do with hdf5)?

stwhite91 commented 5 years ago

Original date: 2018-04-18 11:18:34

The patch above was merged and will be in 6.9.0. We could still rename our library to libmpi but just avoiding the MPI -> AMPI renaming got rid of the basic problem.

stwhite91 commented 5 years ago

Original date: 2018-04-21 15:30:51

We now have a way to build a single libcharm.so, it would be good to follow the same approach and get a single libampi.so as well

libcharm: https://charm.cs.illinois.edu/gerrit/#/c/charm/+/4040/ https://github.com/UIUC-PPL/charm/commit/343d50363d923c0405740c8e469b1e7176b66274