Open stwhite91 opened 6 years ago
Original date: 2018-05-08 02:26:40
Also std::atomic rather than compiler builtins like _sync*
Original date: 2018-05-09 15:59:07
Assigning to Evan as I think he's already accomplished most of this task.
Original date: 2018-05-09 16:00:08
We should probably break this down into a few different subtasks based on the categorical changes left. Some of the really mechanical stuff could be assigned to interns.
Original date: 2018-05-09 16:01:24
Eric Bohm wrote:
Assigning to Evan as I think he's already accomplished most of this task.
The work I've done is only enough to compile the source as C++ without errors or warnings with our current settings. Sam is talking about leveraging C++ to refactor the code.
Original date: 2018-05-10 20:42:37
Added C to C++ renaming tutorial.
Anything else that could benefit from cleanup made possible by C++ and not C?
Original issue: https://charm.cs.illinois.edu/redmine/issues/1898
Now that we compile machine and parts of Converse as C++, we can clean up some parts of the code using templates, STL containers, optional arguments to functions, typed enums, etc.
The following is a procedure for renaming .c files to .C.
git mv
the file(s) in question.$ pwd /Users/evan/charm/src
$ git commit -am "A 1" [charm 020ef6f6d] A 1 1 file changed, 0 insertions(+), 0 deletions(-) rename src/conv-core/{convcore.c => convcore.C} (100%)
$ for i in
git diff --name-only HEAD~1 | sed 's/\.C/.c/' | sed 's,/, ,g' | awk '{print $NF}'
; do ( grep -rFlw "$i" | xargs sed -i "s,${i%.c}\.c,${i%.c}.C,g" ); done$ git commit -am "B 1" [charm c516df959] B 1 13 files changed, 34 insertions(+), 34 deletions(-)
$ git rebase --whitespace=fix HEAD~1 Current branch charm is up to date, rebase forced. First, rewinding head to replay your work on top of it... Applying: B 1