search

charmplusplus / charm

The Charm++ parallel programming system. Visit https://charmplusplus.org/ for more information.
Apache License 2.0
207 stars 50 forks source link

Add test for NETWORK variable #3845

Open VictorEijkhout opened 1 month ago

VictorEijkhout commented 1 month ago

If the variable NETWORK is not set, CMake crashes. Please add a test for this being set before line 41.

mayantaylor commented 1 month ago

Can you clarify how you are running into this issue? Building Charm via the ./build script should not run into this problem. I'm wondering what the use case is for building via cmake direclty (this relates to your other issue as well I think)

VictorEijkhout commented 1 month ago

The use case for using cmake is that I have a build system that sets up all directories and such, and I only have to specify 

CMAKEFLAGS= blah blah blah

and then everything builds.

Custom build scripts mean that I have to set up all that stuff by hand. A cmake installatin means that half an hour from downloading I have a package installed on 4 clusters times 3 compilers each.

Please use an industry standard rather than rolling your own install script. Please?