Call super().__init__() in PoolScheduler __init__

charmplusplus / charm4py

Parallel Programming with Python and Charm++

https://charm4py.readthedocs.io

Apache License 2.0

290 stars 21 forks source link

Call super().init() in PoolScheduler init #216

Open nchristensen opened 2 years ago

nchristensen commented 2 years ago

Subclasses of PoolScheduler can't work with the Pool because a missing attribute __local_free_head causes __addLocal__ to raise an AttributeError. Calling super().__init__() in the PoolScheduler __init__ method seems to fix this since the Chare class sets this attribute in its __init__().

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging 84083a089bce8c3a64dbafc6e986bad65b059850 into 3603cae585d9a04100495b3d798636ff283bdf94 - view on LGTM.com

fixed alerts:

1 for Missing call to `__init__` during object initialization

charmplusplus / charm4py

Call super().__init__() in PoolScheduler __init__ #216

Call super().init() in PoolScheduler init #216