Open nchristensen opened 1 year ago
This pull request introduces 2 alerts when merging 1b08833be5ccc06cd5e0a5f2eaa1042f37dfa5cc into 74791f9eb76b2f032615a1363441d25f8e4c57d2 - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.
This pull request introduces 2 alerts when merging 08cf569e62d65206deede09bfb31303104a35c02 into 74791f9eb76b2f032615a1363441d25f8e4c57d2 - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.
Hi Nick, This is some really cool work! I can help out later this week or early next week to help with testing and documentation.
Cool, that would be great! It could definitely use another pair of eyes.
This pull request fixes 1 alert when merging 9822860898f2afe22b0b2a3e4e2936b4dad065c3 into 74791f9eb76b2f032615a1363441d25f8e4c57d2 - view on LGTM.com
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.
This pull request fixes 1 alert when merging 282a11b237c293e60b42a4e2709f40f0255ed47f into 74791f9eb76b2f032615a1363441d25f8e4c57d2 - view on LGTM.com
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.
This pull request fixes 1 alert when merging b71e4b379ec218655c2d6a40437aeabc22305b24 into 74791f9eb76b2f032615a1363441d25f8e4c57d2 - view on LGTM.com
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.
This pull request introduces 7 alerts and fixes 2 when merging 081d3dca72370f52ab31658a4286414f861c9263 into 74791f9eb76b2f032615a1363441d25f8e4c57d2 - view on LGTM.com
new alerts:
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.
This pull request introduces 7 alerts and fixes 2 when merging 2bbb9a8af0cf76319e785304ae5b59cc2f346b61 into 74791f9eb76b2f032615a1363441d25f8e4c57d2 - view on LGTM.com
new alerts:
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.
This adds a concurrent.futures.Executor implementation for Charm4py so Charm4py can be dropped in wherever
ThreadPoolExecutor
,ProcessPoolExecutor
,MPI4pyPoolExecutor
, etc. is used.A
PoolExecutor
class inpool.py
implements theExecutor
API by calling to equivalentPool
methods. This pull request also makescharm4py.threads.Future
inherit fromconcurrent.futures.Future
and implements its API.TODO:
Future.set_running_or_notify_cancel()
and figure out where to call it. Execution currently hangs without explicitly callingFuture.get()
.