search

charmplusplus / charm4py

Parallel Programming with Python and Charm++
https://charm4py.readthedocs.io
Apache License 2.0
289 stars 21 forks source link

fixes to allow mac builds to work smoothly #248

Closed ritvikrao closed 2 months ago

ritvikrao commented 4 months ago

I made a couple of changes to allow the charm4py build on macs to work smoothly. Note that this only solves the issues that arise after a successful charm++ install has happened; there's an ongoing pr in the charm++ repo to fix charm4py installation issues there.

The first change adds a flag in setup.py to ignore implicit function declaration errors that show up with newer versions of Apple Clang (15.0.0 and up). The second change modifies charm4py/charmlib/ctypes_py to specify that the charm++ library file created by mac builds is libcharm.dylib, not libcharm.so.

ritvikrao commented 3 months ago

I think this should be merged now, with the fix made here: https://github.com/UIUC-PPL/charm/pull/3797

ritvikrao commented 3 months ago

I added changes to the charm4py install documentation to put the current working build procedure first. Additionally, as Sanjay said in the 4/1 Charm4py meeting, any fixes to the implicit function warnings should be part of another pr.

ritvikrao commented 2 months ago

I added an OS call to fix the path in the c_object_store shared object file. it's just a workaround/hack for now

ZwFink commented 2 months ago

We should check that this also works for Apple Silicon macs... @mayantaylor can you confirm?

adityapb commented 2 months ago

@ritvikrao Can you make these changes on top of the main branch so that my commits from the ray branch don't show up