mac arm build and CI addition

charmplusplus / charm4py

Parallel Programming with Python and Charm++

https://charm4py.readthedocs.io

Apache License 2.0

289 stars 21 forks source link

mac arm build and CI addition #259

Closed mayantaylor closed 1 month ago

mayantaylor commented 1 month ago

Updating setup.py for correct mac build:

charm++ build needs the architecture specified as arm8 (undoing incorrect change in #254)
clang installation for charm4py requires architecture specified as arm64
charmlib.so must be replaced with the mac version (.dylib)

ritvikrao commented 1 month ago

I got both the x86 and m1 mac tests to work, but i had to disable thread fork safety checking for it to do so.

ritvikrao commented 1 month ago

Why did you restructure it as a matrix? I split it up because I needed separate run steps for the mac build

matthiasdiener commented 1 month ago

Why did you restructure it as a matrix? I split it up because I needed separate run steps for the mac build

Most of the steps are identical across the different runs; if there are small differences between the steps, we can resolve them in the build script (via e.g. if [[ ${{ matrix.os }} == 'macos-14' ]]; then ...)

matthiasdiener commented 1 month ago

I think this is ready for review @mayantaylor @ritvikrao . I'm not sure if we should add other Python versions or architectures to CI?

ritvikrao commented 1 month ago

i think the tests here are sufficient, this looks good to me