Only use Entry ID<->index maps if necessary

charmplusplus / projections

Performance Analysis Tool for Charm++

Apache License 2.0

5 stars 3 forks source link

Only use Entry ID<->index maps if necessary #141

Open rbuch opened 3 years ago

rbuch commented 3 years ago

In the common case, Entry IDs and indices are both contiguous and start from 0, so these maps are just the identity function. ID->index conversion is on the hot path for drawing Timeline and the boxing/unboxing and map lookup can be relatively costly, so avoid it when possible.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 09ab39192af43e25410c606e92bc2c4f5b64f1b9 into 8ca8a8c55ebb1706269ea659a2735b31dabd2f2d - view on LGTM.com

new alerts:

1 for Boxed variable is never null