charri / Font-Awesome-WPF

FontAwesome controls for WPF+UWP
MIT License
533 stars 145 forks source link

Added click event support for the components. #21

Closed erenhatirnaz closed 8 years ago

charri commented 9 years ago

Thanks for you contribution.

what is the use-case for clickable images / textblocks? Would it not be better to put them inside "clickable" elements - such as Button etc?

erenhatirnaz commented 8 years ago

You're welcome. Yes, you're right but I think it would be more useful that way.

TrabacchinLuigi commented 8 years ago

This seems odd to me, it is more code to mantain to do the same thing that you can achieve nesting it in the clikable element... More code to mantain more bug, more problems

erenhatirnaz commented 8 years ago

I analyzed a bit more and i think you are right, so you can close the pull request.

charri commented 8 years ago

I looked up in the fontawesome documentation what it says about clickable icons and it is advised to be put into or