search

charslab / TranscriberBot

TranscriberBot for Telegram
https://t.me/transcriber_bot
GNU General Public License v3.0
273 stars 38 forks source link

Merge `development` into `master`? #34

Closed turicas closed 2 years ago

turicas commented 3 years ago

I found that the development branch is behind master for some commits but also it has a new merge (PR #24) which hasn't been merged into master yet. Are you going to merge it on master and deploy this new version (supports video files)?

branches

stefanodelbosco commented 3 years ago

At the moment the development branch is the current running version (in a docker container, with this package) But I made a mistake 2 month ago... I forgot to change and upload the new configs file (config/app.json), so the bot didn't recognized the video files... Now there is the correct config file, so it will be able to recognize the video files and now the #24 will works

About the merge development into master, there are some things to do (for example GH Action, docker run instruction, etc) and at the moment I don't have time to do D:

turicas commented 3 years ago

@stefanodelbosco thanks a lot! :) I didn't understand what should be done for the merge, if I can help please describe the needed actions. :)

stefanodelbosco commented 2 years ago

@turicas, I finally merge the development into master. At the moment the running version is the master ('latest' of docker image)