[New request] Add the possibility to track custom player based on AVPlayer

chartbeat-labs / chartbeat-ios-sdk

Other

2 stars 3 forks source link

[New request] Add the possibility to track custom player based on AVPlayer #4

Open fredhdroz opened 7 years ago

fredhdroz commented 7 years ago

For an SDK, the "MediaPlayerTracker" is a bit too restrictive. It only allows to track the deprecated "MPMoviePlayerController"... It should be possible to track any custom player using AVPlayer.

Is there any protocol we could implement to track any AVPlayer ?

ollieatkinson commented 6 years ago

This would be really good, I also noticed we are getting a warning when compiling.

Pods/Chartbeat/Chartbeat.framework/Headers/MediaPlayerTracker.h:29:28: 'MPMoviePlayerController' is deprecated: first deprecated in iOS 9.0 - Use AVPlayerViewController in AVKit.