Undefined variable in textacy.spacier.utils.merge_spans

[popelucha]

variable ents is not defined

Expected Behavior

for start_char, end_char, label in ents: <- ents is not defined

Current Behavior

Possible Solution

should be doc.ents

Steps to Reproduce (for bugs)

Context

Your Environment

• operating system:
• python version:
• spacy version:
• installed spacy models:
• textacy version:

[bdewilde]

Thanks for the bug report. I think it should actually be ents => spans, where spans is defined in the preceding line: https://github.com/chartbeat-labs/textacy/blob/master/textacy/spacier/utils.py#L97

Does that seem right to you?

[popelucha]

Thanks for the bug report. I think it should actually be ents => spans, where spans is defined in the preceding line: https://github.com/chartbeat-labs/textacy/blob/master/textacy/spacier/utils.py#L97

Does that seem right to you?

Absolutely, thanks for reviewing it.