fix textacy.io.spacy.read_spacy_docs - Githubissues

chartbeat-labs / textacy

NLP, before and after spaCy

https://textacy.readthedocs.io

Other

2.21k stars 249 forks source link

fix textacy.io.spacy.read_spacy_docs #229

Closed judahrand closed 5 years ago

judahrand commented 5 years ago

Description

Fixes string type compatibility between msgpack and Spacy. This should also be compatible between python 2.x and 3.x though I haven't tested it.

Motivation and Context

Relates to Issue #228

How Has This Been Tested?

Tested in the use case described in Issue #228

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation, and I have updated it accordingly.

bdewilde commented 5 years ago

Hey @Jude188 , thanks for this, and please pardon the belated response. Everything looks correct! I'm looking to clean this function up (if possible) independent of this bug fix, and rather than deal with rebasing and such, I'm just going to re-implement your changes directly in master. Will attribute credit to you. :)