Issue241 rcm param and ducktyping for models

zf109 commented 5 years ago

Description

Solving Issue 241, please see details there.

Motivation and Context

A feature request: allows duck typing for instantiate TopicModel class and allow passing rc_params to the drew_termite_plot function so that the termite plot can be more flexible.

How Has This Been Tested?

for allow duck typing, as per in here
for allow passing params, these were tested manually by plotting termite plot within Jupyter notebook and change the rc_params and see if the plot changed as expected.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation, and I have updated it accordingly. (inline documentation only though)

zf109 commented 5 years ago

@bdewilde hey, as promised, sent over a pull request about the two enhancement mentioned. Cheers, zf

bdewilde commented 5 years ago

Hey @zf109 , thanks for the PR! I've been busy packing / moving / unpacking my life the past couple weeks, so please bear with me a little longer as I get back up to speed. Thanks again, will review this soon. :+1:

bdewilde commented 5 years ago

Actually, I'm just going to merge this in and make that minor hotfix in develop. Thanks very much for contributing! :shipit:

bdewilde commented 5 years ago

Welp, looks like it actually went into master. I'll figure it out. 😅

zf109 commented 5 years ago

@bdewilde ha, great, sorry was a bit busy last few weeks and on holiday then so didn't see your comments... thanks a lot for merging it :)

chartbeat-labs / textacy