preprocess text broken - Githubissues

chartbeat-labs / textacy

NLP, before and after spaCy

https://textacy.readthedocs.io

Other

2.21k stars 249 forks source link

preprocess text broken #250

Closed nyejon closed 5 years ago

nyejon commented 5 years ago

steps to reproduce

Just use preprocess_text

if normalize_unicode is True: text = normalize_unicode(text, form="NFC")

expected vs. actual behavior

text = normalize_unicode(text, form="NFC")

TypeError: 'bool' object is not callable

possible solution?

Change the name of normalize_unicode for either the bool, or method.

textacy version: 0.7.1

bdewilde commented 5 years ago

Oh gosh 🤦‍♂ I can't believe I missed that — and didn't test for it. Will fix ASAP.

bdewilde commented 5 years ago

Alright, the fix is up on master. This is as good a prompt as any to prioritize improving textacy's text preprocessing functionality for the next release. Thanks for the quick heads-up. :+1: