search

chartbeat-labs / textacy

NLP, before and after spaCy
https://textacy.readthedocs.io
Other
2.21k stars 249 forks source link

scikit-learn > 0.24 #319

Closed fabaff closed 3 years ago

fabaff commented 3 years ago

cikit-learn 0.24.1 was released a while ago.

https://github.com/chartbeat-labs/textacy/blob/cdedd2351bf2a56e8773ec162e08c3188809d486/setup.cfg#L51

The Nix packages is already at 0.24.1 and this breaks the build.

Do you have any plans to allow scikit-learn > 0.24?

Thanks

bdewilde commented 3 years ago

Hi @fabaff , I've started updating textacy to work with spacy v3 (on the develop branch), and plan to allow for newer scikit-learn there. It's not trivial, since in the current setup I have to train a new language identification model using sklearn v0.24 before textacy will work with it. Will let you know here when it's good to go.

bdewilde commented 3 years ago

Hi again, just following up to confirm that this version cap has been removed on the develop branch, and everything seems to be working fine with the latest version of scikit-learn. I won't close this issue out until the fix is released, but please feel free to checkout the dev branch in the meantime.

bdewilde commented 3 years ago

Update: this has been resolved as of today's v0.11 release: https://github.com/chartbeat-labs/textacy/releases/tag/0.11.0