Changes for spacy 3.0 - Githubissues

chartbeat-labs / textacy

NLP, before and after spaCy

https://textacy.readthedocs.io

Other

2.21k stars 249 forks source link

Changes for spacy 3.0 #322

Closed datanizing closed 3 years ago

datanizing commented 3 years ago

Hi Burton,

as discussed with Jens I have created a few changes to make (parts of) textacy work with spacy 3.0.

Description

Take care of API changes in spacy 3.0 Make passing of numpy arrays possible

Motivation and Context

Make it work with latest spacy

How Has This Been Tested?

Ran the normal examples

Screenshots (if appropriate):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation, and I have updated it accordingly.

bdewilde commented 3 years ago

Hi @datanizing , your changes (or in one case, a basically equivalent change) are now live in the develop branch — plus a big update for the preprocessing subpackage. As such, I'm going to close this PR, but will give you proper credit in the next release notes. Thanks for jump-starting this process!