search

chartes / lettres-vue

Site de l’application Ecco (Édition Collaborative de COrrespondances)
https://dev.chartes.psl.eu/ecco/
1 stars 3 forks source link

Mirador Viewer : issue with source data (gallica IIIF manifest) #130

Closed vicpsl closed 7 months ago

vicpsl commented 7 months ago

In order to display the images related to a specific document, Ecco's backend (manifest_factory.py) fetches the gallica IIIF manifest for the volume of a particular witness and filter its canvases in the json key "sequences" (["sequences"][0]["canvases"]) :

On a regular basis, the gallica IIIF manifest returns invalid image width and height :

["sequences"][0]["canvases"][canvas index]["width"] = -1 ["sequences"][0]["canvases"][canvas index]["height"] = -1

as shown below :

This is causing the following errors :

Assertion failed: [Viewport._setContentBounds] bounds.width must be greater than 0 Assertion failed: [Viewport._setContentBounds] bounds.height must be greater than 0

image

in Mirador's OpenSeadragon dependency.

This is causing the Ecco's Mirador Viewer to fail irremediably : it needs to be closed and reopened. The images cannot be accessed otherwise (even by clicking on Previous/Next or Zoom reset or accessing the image via Mirador's Gallery View).

vicpsl commented 7 months ago

Closed by commit chartes/lettres-app@f5fd3a4996a7022cfcbb1dd1bf01ed8b04872f68.