search

chartist-js / chartist

Simple responsive charts
https://chartist.dev
MIT License
13.33k stars 2.54k forks source link

fix: SvgPath.parse fails on negative values #1360

Closed Arantiryo closed 1 year ago

Arantiryo commented 1 year ago

Implements suggested fix from #1248.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1360 (e54f50d) into main (5f716c3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          42       42           
  Lines        1231     1231           
  Branches      322      322           
=======================================
  Hits          908      908           
  Misses        239      239           
  Partials       84       84
Impacted Files Coverage Δ
src/svg/SvgPath.ts 97.70% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gionkunz commented 1 year ago

Hi there! Thanks for the PR! Would you mind adding a few tests for this case? Cheers!

Arantiryo commented 1 year ago

Hi @gionkunz! Yes, absolutely! Do you think that covers it or should I add anything else?

gionkunz commented 1 year ago

Thanks, @Arantiryo , I think that's sufficient at the moment. Cheers!