chartist-js / chartist

Simple responsive charts

https://chartist.dev

MIT License

13.33k stars 2.54k forks source link

Add styles for new documentation website #1367

Closed ariarzer closed 1 year ago

gionkunz commented 1 year ago

Hi! Thanks for the PR can you maybe add a screenshot that gives an impression of the styles so people can take a llok without installing locally? Cheers!

dangreen commented 1 year ago

@gionkunz https://deft-narwhal-c4182a.netlify.app

igorlukanin commented 1 year ago

@gionkunz Do you mean a screenshot of a website (@dangreen deployed it here: https://deft-narwhal-c4182a.netlify.app/) or a screenshot of a chart added to the website?

gionkunz commented 1 year ago

Thanks a lot for the creation of the styles.

Heres some feedback from my side:

I think the chartist icon should always be on yellow background. In the header it would look much better like this:
Hover color on links looks nice in the chartist red on bright background but in the header, it would be better to use the chartist yellow as the hover color.
Something is not okay with the colors in the mobile menu:
I think we should disable the theme chooser / brightness chooser and always provide the same theme (currently the bright one). This is not a tool you're using every day but quickly check for some documentation. I think it's okay if we follow just one branding color theme.
Currently the Prism code highlighter theme is completely different than Chartist. We have also created a code highlighter Theme on the old website which blends in very nicely. Maybe we can use the same colors? Now: Old Website:

ariarzer commented 1 year ago

I will fix your comments code highlight tomorrow 👍🏻

ariarzer commented 1 year ago

Hi) Sorry for waiting, I was a little bit sick. I done all you comments except the code highlighting. It seems that this is not an easy task for me, and I left it to my colleagues.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@164e765). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1367   +/-   ##
=======================================
  Coverage        ?   74.41%           
=======================================
  Files           ?       42           
  Lines           ?     1247           
  Branches        ?      326           
=======================================
  Hits            ?      928           
  Misses          ?      238           
  Partials        ?       81

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dangreen commented 1 year ago

@gionkunz please check out https://deft-narwhal-c4182a.netlify.app

gionkunz commented 1 year ago

@dangreen do you think it would be a big task to reuse the code block styles we have on the old documentation site?

gionkunz commented 1 year ago

@ariarzer awesome work! Thank you so much, it looks more and more like native chartist :-P

dangreen commented 1 year ago

@gionkunz Done https://deft-narwhal-c4182a.netlify.app.

gionkunz commented 1 year ago

Great thank you so much!