search

chartjs / Chart.js

Simple HTML5 Charts using the <canvas> tag
https://www.chartjs.org/
MIT License
63.9k stars 11.88k forks source link

Update OffscreenCanvas documentation, as it is widely available now #11823

Closed joliss closed 2 days ago

joliss commented 3 days ago

As documented by MDN, OffscreenCanvas is widely available as of 2023, so this pull request updates the documentation accordingly.

I tested rendering with OffScreenCanvas on my own app, and it works with Chrome and Firefox.

However, in Safari 17.5 and 18.0-preview on macOS, it doesn't render anything for me when I switch from canvas to canvas.transferControlToOffscreen(). There's unfortunately no error message in the console. I wasn't able to reproduce my problem with a simple test case -- the CodePen works fine in Safari -- so don't really have a good bug report to submit. I think it's also quite possible that there's something else going on in my code that Safari is tripping over.

So perhaps for the moment, it might be worth merging this documentation patch. If people run into issues with Safari (or I can reproduce my issue with a smaller example) down the line, we can always open a new issue for it then.

blueyedblues commented 1 day ago

gayalea risley

On Sat, Jun 29, 2024, 8:51 AM Evert Timberg @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/chartjs/Chart.js/pull/11823#pullrequestreview-2149686664, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOYJ6JLMOR2PRH6YTPX7YDZJ3JYJAVCNFSM6AAAAABKDI4HGKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBZGY4DMNRWGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>