typing of version 3.0.0-beta.8 is broken

chartjs / Chart.js

Simple HTML5 Charts using the <canvas> tag

https://www.chartjs.org/

MIT License

64.56k stars 11.9k forks source link

typing of version 3.0.0-beta.8 is broken #8304

Closed jnizet closed 3 years ago

jnizet commented 3 years ago

Expected Behavior

version 3.0.0-beta.8 should be usable in TypeScript

Current Behavior

The compilation fails due to what seems to be an error in the chart.js typings:

Error: node_modules/chart.js/dist/chart.esm.d.ts:197:7 - error TS7051: Parameter has a name but no type. Did you mean 'arg0: ChartArea'?

197  draw(ChartArea): void;

Environment

Chart.js version: 3.0.0-beta.8
Browser name and version: NA
Link to your project: NA
TypeScript version: 4.0.5

santam85 commented 3 years ago

Is a new beta going to be released soon with this fix?

etimberg commented 3 years ago

@santam85 a new beta has been released fixing this and a couple of other issues

jnizet commented 3 years ago

Thanks for the fix and the new release @LeeLenaleee @etimberg ❤️