search

chartjs / awesome

A curated list of awesome Chart.js resources and libraries
MIT License
2.02k stars 128 forks source link

add chartjs-adapter-dayjs #45

Closed mojoaxel closed 2 years ago

mojoaxel commented 2 years ago

Please Describe Your Addition

add the chartjs-adapter-dayjs adapter.

LeeLenaleee commented 2 years ago

I am against adding this adapter in its current form to the list of available adapters.

First in the documentation it states you can install the adapter with CDN using the following link: https://cdn.jsdelivr.net/npm/chartjs-adapter-dayjs@1.2.0 but this version does not exist. Looking through owner of packages and commits made to the repo it seems it went further under the chartjs-adapter-dayjs-3 naming in which the version does exist.

But if you then try to use https://cdn.jsdelivr.net/npm/chartjs-adapter-dayjs-3@1.2.0 to import the adapter from the CDN or even the latest version it does not work since it only seems to build an ESM version of the adapter and tries to re export it by requiring it in the browser with normal version like the docs said. But this will give errors since process is not defined in the browser.

So I think in its current form this will give more confusion as that it could take away

mojoaxel commented 2 years ago

@LeeLenaleee Thanks for pointing out the bad state of the dayjs-adapters! I'll close this for now and hope that someone will took up the existing implementations.