search

chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js
MIT License
33 stars 23 forks source link

Update rollup and add ESM output #17

Closed krumware closed 4 years ago

krumware commented 4 years ago

This updates the rollup config to have some parity with the updated chart.js rollup config, and also adds ESM output.

A unit test needs to be updated, but a fix is available already in #12 ~This also updates the chartjs version like #12~

~depends on #12~ closes #16

krumware commented 4 years ago

Resolved the items for review and did some extra cleanup. I'm with you, I don't think those plugins were necessary, just included them for parity with Chart.js' rollup.

One thing about the 2.8 vs 3.0 is I'm concerned that folks might mistakenly try to use the esm version with the non-esm-supported chart.js (2.8 said imports were supported, but it didn't work like it does with modules). I dropped it back anyways.

Tagged this as a WIP though, because I need to test the esm files produced here, in a live environment, or update the unit tests to test both types.

iddings commented 4 years ago

Is there still work to be done on this? If so, I'm happy to help. ES6 builds would make my life much easier.

krumware commented 4 years ago

Thanks for the Bump @iddings. I simply haven't tried the suggestion of removing the cleanup and babel plugins suggested above (short on free time and lost track). I'll give it a quick update.

krumware commented 4 years ago

Addressed the last few items, should be good to go now 👍

iddings commented 4 years ago

Thanks for the Bump @iddings. I simply haven't tried the suggestion of removing the cleanup and babel plugins suggested above (short on free time and lost track). I'll give it a quick update.

Thanks for taking the time to work on this @krumware. Much appreciated!