search

chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js
MIT License
33 stars 24 forks source link

Release 0.2.2 #24

Closed benmccann closed 3 years ago

Ben3eeE commented 3 years ago

It seems like 0.2.2 was not tagged and released after this was merged. Is that because the build is failing?

benmccann commented 3 years ago

Where do you see that the build is failing? The tests seem to pass locally for me although there are linting issues, which maybe would stop a release, so I sent a fix for that: https://github.com/chartjs/chartjs-adapter-luxon/pull/25

Ben3eeE commented 3 years ago

I was looking in at the badge in the readme file to see that the build failed. Yeah, it seems to only be linting issues. It seems that PRs don't run on travis so this was not noticed before merging to release?

I am trying this out with chartjs 3.0.0-alpha2 with tree-shaking and ran into the issues that was fixed by PR https://github.com/chartjs/chartjs-adapter-luxon/pull/20. Linking this library locally from master fixed this issue but then I run into another issue:

This method is not implemented: either no adapter can be found or an incomplete integration was provided.

Importing like this:

import { Chart, LineController, Line, Point, LinearScale, TimeScale, Title } from 'chart.js';
import 'chartjs-adapter-luxon';

Chart.register(LineController, Line, Point, LinearScale, TimeScale, Title);

It seems like the adapter is not registered correctly. Not sure if I am importing it incorrectly. And I can't find any documentation on how to use this library with tree-shaking.