chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js
MIT License
33 stars 24 forks source link

Fix parsing of JS Date objects #30

Closed etimberg closed 3 years ago

etimberg commented 3 years ago

The if conditions were in the wrong order so we tried to parse JS Date objects as Luxon DateTime objects leading to incorrect results.

const x = new Date();
typeof x // "object"
coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 630220978


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.js 1 2 50.0%
<!-- Total: 1 2 50.0% -->
Totals Coverage Status
Change from base Build 630196825: 3.5%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls
coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 630220978


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.js 1 2 50.0%
<!-- Total: 1 2 50.0% -->
Totals Coverage Status
Change from base Build 630196825: 3.5%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls