Add adapter options - Githubissues

chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js

MIT License

33 stars 24 forks source link

Add adapter options #5

Closed jonrimmer closed 5 years ago

jonrimmer commented 5 years ago

Fixes #3

Passes through the adapter options to each of Luxon's factory methods (fromMillis(), fromFormat()`, etc.) so that they can be configured with a timezone and other parameters.

Also adds a basic testing setup.

benmccann commented 5 years ago

Thanks for this! It looks pretty good overall. Can you add some docs for this feature to the README as well? (probably by updating the existing "Configuration" section)

jonrimmer commented 5 years ago

@benmccann I've added some text to the readme, let me know if you think it needs anything more.

jonrimmer commented 5 years ago

@simonbrunel I think I resolved everything.

simonbrunel commented 5 years ago

@jonrimmer thanks, looks really good!

Just a missing newline at the end of test/.eslintrc.yml and some rest of triggerMouseEvent.

simonbrunel commented 5 years ago

@jonrimmer We also need Travis to run tests after gulp build and you will certainly need:

before_script:
  - export DISPLAY=:99.0
  - sh -e /etc/init.d/xvfb start

as in the datalabels plugin.

jonrimmer commented 5 years ago

@simonbrunel I've added the tests to Travis (and also fixed a bug in a test it revealed).

simonbrunel commented 5 years ago

Thanks @jonrimmer

benmccann commented 5 years ago

Any chance we could get a new release with this functionality?