chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js
MIT License
33 stars 23 forks source link

Add Luxon supported options documentation to README #53

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

This PR is adding documentation about which options can be set to configure Luxon.

As reported by PR #42 and issue #46, these could not be well-known.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2033284960


Totals Coverage Status
Change from base Build 1660678495: 0.0%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2033284960


Totals Coverage Status
Change from base Build 1660678495: 0.0%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls
stockiNail commented 2 years ago

@benmccann thank you very much for your review. My English is not so good! I have changed INTL to Intl also in the other options description where it was used.

benmccann commented 2 years ago

thank you! looks like a nice change. I can't merge, so will need to wait for someone else for that