chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js
MIT License
33 stars 22 forks source link

Improve the use of the custom options #64

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

This PR is:

  1. adding the options to parse function when DateTime is created by an object (was missing) in order to have a DateTime configured with user options
  2. removing the options from toFormat method of Luxon because DateTime is always created with the options (see _create function)
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2649783165


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.js 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Totals Coverage Status
Change from base Build 2085427674: 0.0%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls
stockiNail commented 2 years ago

fix #67