Change dependencies of Luxon versions

chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js

MIT License

33 stars 24 forks source link

Change dependencies of Luxon versions #65

Closed stockiNail closed 1 year ago

stockiNail commented 1 year ago

Fix #61

stockiNail commented 1 year ago

@benmccann @kurkle I'd like to spend time to increase the test cases in order to test all methods of the interface to be sure that to every new Luxon version the adapter will continue working. What do you think?

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2662756077

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.727%

Totals
Change from base Build 2085427674:	0.0%
Covered Lines:	24
Relevant Lines:	31

💛 - Coveralls

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2669462457

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.727%

Totals
Change from base Build 2085427674:	0.0%
Covered Lines:	24
Relevant Lines:	31

💛 - Coveralls

kurkle commented 1 year ago

@benmccann @kurkle I'd like to spend time to increase the test cases in order to test all methods of the interface to be sure that to every new Luxon version the adapter will continue working. What do you think?

Sounds good!

stockiNail commented 1 year ago

Converted in draft in order to change also the package-lock.json with last modules (for instance Chart,js 3.8.0)

stockiNail commented 1 year ago

Applied last versions of dependencies.