chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js
MIT License
33 stars 22 forks source link

Improve typeof invocation when parsing #68

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

The typeof was invoked twice in the parse method, to check if undefined (in if statement) and later to get the type. Moved before consistency check in order to invoke only one when the value argument is not null.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2668870414


Files with Coverage Reduction New Missed Lines %
src/index.js 2 72.73%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 2085427674: 0.0%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2668870414


Files with Coverage Reduction New Missed Lines %
src/index.js 2 72.73%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 2085427674: 0.0%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls