Update Development section of README

chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js

MIT License

33 stars 22 forks source link

Update Development section of README #69

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

README was containing teh develpment section referring gulp, not used anymore.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2670600659

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.727%

Totals
Change from base Build 2085427674:	0.0%
Covered Lines:	24
Relevant Lines:	31

💛 - Coveralls

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2670600659

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.727%

Totals
Change from base Build 2085427674:	0.0%
Covered Lines:	24
Relevant Lines:	31

💛 - Coveralls

stockiNail commented 2 years ago

@benmccann before merging, what about to create a milestone 1.2.0 and add labels to all PRs in order to have a good release note? What do you think?

benmccann commented 2 years ago

I don't have permission to merge or cut releases, so am happy with whatever organizational solution the person in charge of that would like to use :smile:

stockiNail commented 2 years ago

Thank you @kurkle for your approval and apologize in advance for my further question:

Does it make sense to create new milestone (1.2.0) and to set the labels to all PRs?

kurkle commented 2 years ago

Sure. And do the release too.

stockiNail commented 2 years ago

Thank you! I didn't want to push you to do it. I was just curious why there weren't.