chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js
MIT License
33 stars 24 forks source link

Use chart "locale" if it is not specified in the adatpter options #72

Closed stockiNail closed 1 year ago

stockiNail commented 1 year ago

Fix #71 Answer to comment https://github.com/chartjs/chartjs-adapter-luxon/issues/46#issuecomment-983796300

Missing

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2766431625


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.js 0 2 0.0%
<!-- Total: 0 2 0.0% -->
Totals Coverage Status
Change from base Build 2736928659: -6.7%
Covered Lines: 31
Relevant Lines: 33

💛 - Coveralls
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2766431625


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.js 0 2 0.0%
<!-- Total: 0 2 0.0% -->
Totals Coverage Status
Change from base Build 2736928659: -6.7%
Covered Lines: 31
Relevant Lines: 33

💛 - Coveralls
LeeLenaleee commented 1 year ago

@stockiNail chart.js v3.9 has been released with the necessary changes

stockiNail commented 1 year ago

Thank you @LeeLenaleee. I need to finish a couple of other things for another project and then I'll take care.

LeeLenaleee commented 1 year ago

Yeah no problem, no hurry, just wanted to let you know :)

stockiNail commented 1 year ago

Yeah no problem, no hurry, just wanted to let you know :)

Ready for review! Thank you!

kurkle commented 1 year ago

@stockiNail can you submit a version bump?

stockiNail commented 1 year ago

@stockiNail can you submit a version bump?

Yes, give some minutes

stockiNail commented 1 year ago

@stockiNail can you submit a version bump?

@kurkle done!