search

chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js
MIT License
33 stars 24 forks source link

chartjs-adapter-luxon 1.2.0 is incompatible with chart.js 4.x #76

Closed StephanTLavavej closed 1 year ago

StephanTLavavej commented 1 year ago

I'm seeing the following error when I attempt to update to chart.js 4.x, released ~5 hours ago:

D:\GitHub\chart>npm install chart.js@latest chartjs-adapter-luxon@latest
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: stl-status-chart@1.0.0
npm ERR! Found: chart.js@4.0.1
npm ERR! node_modules/chart.js
npm ERR!   chart.js@"4.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer chart.js@"^3.0.0" from chartjs-adapter-luxon@1.2.0
npm ERR! node_modules/chartjs-adapter-luxon
npm ERR!   chartjs-adapter-luxon@"1.2.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

This is similar to #61 which happened when luxon updated its major version.

hugo-valcourt commented 1 year ago

I tried chart4 on my project (with --force), and I had no problem with chartjs-adapter-luxon.

Should be easy to upgrade to chart4

StephanTLavavej commented 1 year ago

Verified that the chartjs-adapter-luxon 1.2.1 release works for me - thanks! :heart_eyes_cat: