search

chartjs / chartjs-adapter-luxon

Luxon adapter for Chart.js
MIT License
33 stars 23 forks source link

Change CHART.JS dependency to version 4 #77

Closed stockiNail closed 1 year ago

stockiNail commented 1 year ago

Fix #76

benmccann commented 1 year ago

peerDependencies needs to be updated to fix the error. You could change it to >=3.0.0 in order to support both Chart.js 3 and 4

stockiNail commented 1 year ago

peerDependencies needs to be updated to fix the error. You could change it to >=3.0.0 in order to support both Chart.js 3 and 4

Thank you @benmccann ! Done!

benmccann commented 1 year ago

Thanks for taking a look @kurkle! I don't have the ability to merge on this repo. Would you be able to merge it and cut a new release?

nook24 commented 1 year ago

This breaks dependencies for all who are using "chartjs-adapter-luxon": "^1.2.0" in their package.json. npm will install chartjs-adapter-luxon in version 1.2.1 which depends on Chartjs 4 which is a breaking change.

Could you please release chartjs-adapter-luxon 1.2.2 which will depend on Chartjs 3.x again to fix this? Took me a while to find this.

// Edit I guess the change from "chart.js": "^3.0.0", to "chart.js": ">=3.0.0", is is why my npm install installs Chartjs 4

kurkle commented 1 year ago

// Edit I guess the change from "chart.js": "^3.0.0", to "chart.js": ">=3.0.0", is is why my npm install installs Chartjs 4

Do you have chart.js as dependency at all? it should not install v4 if you have v3 already.