Closed stockiNail closed 4 years ago
I don't know that I'm necessarily against the feature, but if you want i18n you're really much better off using Luxon. It results in much smaller bundles because it uses the browser's built-in i18n support
@benmccann ok I agree because could make sense to use Luxon if you need I18N. Thank you very much
I'm thinks this option should be implemented, because without this function, adapter useless. Not all world speaks on English.
For example, if my old app already uses moment and I can't migrate to another library, it's cool if I can use function which already exist, but I can't use it.
About problem with size app, must thinks who use this library. Also, this function not make library weigher
Ok, I found another solution. If you execute this code before usage Chart.js, right locale will be applied
import moment from 'moment';
moment.locale('cz');
Currently the adapater is not managing the I18N.
Nevertheless Moment.js is supporting I18N and due to CHART.JS 3 introuced the locale options, maybe it could make sense to add this kind of support also for Moment adapter.
In my opinion to use I18N in moment, the user should:
What do you think? If you think it could be helpful, I can try to submit a PR.