search

chartjs / chartjs-chart-financial

Chart.js module for charting financial securities
MIT License
721 stars 196 forks source link

demo links in the readme seems to be broken #104

Open bboydflo opened 2 years ago

bboydflo commented 2 years ago

Hi, I just wanted to give a heads up that at least 2 links in the readme of this plugin are broken. I found them in the Related plugins section

❌ chartjs-plugin-crosshair (demo) ❌ chartjs-plugin-streaming (demo)

benmccann commented 2 years ago

I fixed one and asked about the other https://github.com/AbelHeinsbroek/chartjs-plugin-crosshair/issues/85

abhinavsood commented 1 year ago

@benmccann chartjs-plugin-crosshair does not seem to be active anymore. It's been broken for a while - not just the link, but the plugin does not work with chartjs v3 and fixes don't seem to be coming.

benmccann commented 1 year ago

Looks like there's a v3 branch, but they've been slow to update things: https://github.com/AbelHeinsbroek/chartjs-plugin-crosshair/pull/65#issuecomment-872903672. I'll ask for an update there

abhinavsood commented 1 year ago

Looks like there's a v3 branch, but they've been slow to update things: AbelHeinsbroek/chartjs-plugin-crosshair#65 (comment). I'll ask for an update there

Thank you, @benmccann ! Are there any planned updates for this plugin? I'd love to be able to use the latest version of ChartJS (https://github.com/chartjs/chartjs-chart-financial/issues/128 ) and candlestick candles (high/low) disappear if the dataset is hidden and shown again (https://github.com/chartjs/chartjs-chart-financial/issues/103 , https://github.com/chartjs/chartjs-chart-financial/issues/117 )

I am not a JS developer, but if you could point me to the relevant bits of code, I could take a stab at fixing them.