Upgrade to chartjs v4 and fix bugs

chartjs / chartjs-chart-financial

Chart.js module for charting financial securities

MIT License

720 stars 195 forks source link

Upgrade to chartjs v4 and fix bugs #170

Closed santam85 closed 3 months ago

santam85 commented 4 months ago

Thanks for contributing.

[X] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

Description

Upgraded the library to work with Chart.js v4. Change of configuration APIs was needed in order to avoid Chart.js errors. Improved the testing examples in docs to showcase improved animations, color defaults matching the default Chart.js theme, updated code style, linting and packaging to match Chart.js standards.

Testing

Check docs/index.html

santam85 commented 3 months ago

there's really no way to review this with code changes and formatting changes mixed together. it probably would have been better to do the reformatting as a separate PR from the actual changes

agreed, I jumped the gun a bit here, in the spirit of expediting alignment with the parent project.

benmccann commented 3 months ago

I'll leave it up to you then. Go ahead and merge if you feel confident enough in it. I don't think there's much help I can provide from looking at the diff

santam85 commented 3 months ago

Sounds good, will add a bit more information about the changes in the README.md and then merge/release.