Move helpers declaration inside exports so that Chart reference is accessible

chartjs / chartjs-chart-financial

Chart.js module for charting financial securities

MIT License

725 stars 197 forks source link

Move helpers declaration inside exports so that Chart reference is accessible #19

Closed webworker01 closed 6 years ago

webworker01 commented 6 years ago

Hello, I was receiving some errors because this Chart was not in scope when this line was ran. Moving it inside the export seems to fix it. Does this make sense to you guys?

Thanks for contributing.

[X] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

mattsims commented 6 years ago

Are you sure you are including the base Chart JS bundle before you include the financial script?

benmccann commented 6 years ago

@webworker01 it seems like most people don't need this. I'm curious why only you are hitting this. Any response to Matt's question?

benmccann commented 6 years ago

All references to helpers should now be inside the export. Closing this because src/controller.financial.js no longer uses helpers. Please let me know if you run into any other trouble with this