Closed loicbourgois closed 6 years ago
Do we need a new docs directory? Can we just use the existing samples directory?
https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/
It looks like GitHub only accepts master or master/docs We could remove samples/ and use the following structure for docs/ :
docs/
index.html
samples/
candlestick.html
ohlc.html
What do you think ?
Ok, I like the idea of consolidating everything in the docs directory
@loicbourgois thanks for this!
I seem to be having some trouble publishing the docs. I've updated the setting below on GitHub. Not sure if there's anything else I need to do
Thanks for contributing.
Description
OHLC
Add an OHLC controller extending controller.financial.js Add an OHLC element extending element.candlestick.js Add ohlc samples
Out of the box examples
Add a /docs folder to store examples. These examples can be hosted using Github Pages. This could be a solution for issue #5.
Transparent candlestick
The line from high to low was visible if the filling color was transparent. Now the line is drawn in 2 step, so it does not go behind the rectangle.