search

chartjs / chartjs-chart-financial

Chart.js module for charting financial securities
MIT License
743 stars 199 forks source link

NPM Registry as beta or @next #35

Closed davidkassa closed 2 years ago

davidkassa commented 6 years ago

I know that this is not in the npm registry yet. Would you consider adding it as a -beta.x or with a @next tag? It would get more adoption while setting the expectation that it's not ready for prime time. This is a pattern that other libraries, such as vuefire with firestore support, has used.

ferndot commented 5 years ago

Can you please revisit this. It would be super helpful.

juliengloria commented 4 years ago

After years ... still no NPM ? :(

JPLeoRX commented 4 years ago

Any luck with getting it onto NPM? How can I use this in my project? (Sort of nood with js here, so literally have no clue what to do when dependency is not listed on NPM)

santam85 commented 3 years ago

@benmccann would you consider looking into publishing this as a beta (and next label)? I'd like to stop using submodules for https://github.com/valor-software/ng2-charts/pull/1276

santam85 commented 3 years ago

Opened https://github.com/chartjs/chartjs-chart-financial/pull/95 with the changes required.

santam85 commented 3 years ago

@benmccann it's me bothering you again! 😄 What's missing in order to release this?

benmccann commented 3 years ago

@santam85 my main hesitation would be putting it up on npm when I'm not really around to support it. Would you have any interest in becoming a maintainer for this?

santam85 commented 3 years ago

Yeah sure, happy to help

santam85 commented 3 years ago

How do we go about making it happen?

benmccann commented 3 years ago

I just invited you to the repo. You'd probably need to coordinate with @etimberg and perhaps @kurkle on the logistics of getting a package published on npm. I'm not quite sure how that's managed and don't have access to everything required. Hopefully we can set it up on the CI

santam85 commented 2 years ago

@etimberg any way of communicating with you/the team other than github PR comments? Any example I should follow in setting up npm release pipelines for this lib?

etimberg commented 2 years ago

Sorry about that @santam85, I was away on vacation at the end of august and missed this. The easiest way could be to join the chart.js slack channel and we can communicate there. You could copy the actions from https://github.com/chartjs/Chart.js/ which will automatically use some org specified secrets for deploying to npm.

santam85 commented 2 years ago

Package is there: https://www.npmjs.com/package/chartjs-chart-financial