chartjs / chartjs-chart-financial

Chart.js module for charting financial securities
MIT License
743 stars 199 forks source link

Improved samples #5

Closed mce1978 closed 6 years ago

mce1978 commented 7 years ago

I just want to try this out. Could you please provide a sample that works out of the box in the samples folder?

I am looking at index.html. Chart.bundle.js could perhaps be a cdn reference? Chart.Financial.js could be prebuilt and available?

Well done!

benmccann commented 7 years ago

Yes, it will be nice to publish some samples (possibly on GitHub pages) that you can see without checking out the repo

It's useful during development to have samples that point to the local version, so I don't want the version in the samples directory to lose that functionality

tapir commented 7 years ago

Also sample is now effectively not functional since there is no documentation how to build Chart.Financial.js

mce1978 commented 7 years ago

Would it be too much work to add a sample that uses the latest working chart.financial.js ?

I really want to try this but I am not using your build environment.

benmccann commented 7 years ago

I've added instructions for building to the README

ShareinSK commented 7 years ago

On which port is the sample running?

joepsyko commented 7 years ago

Thanks for adding instructions, I tried the chart, I think I'll use it in my project

ShareinSK commented 7 years ago

How do I see the sample app? I have downloaded and installed dependencies. When i run gulp i dont see the sample app getting started

And how can i include this in my app?

I am new to this. Pls help

joepsyko commented 7 years ago

You should see the "samples" directory which contains the example

ShareinSK commented 7 years ago

How can we include this in our app.

joepsyko commented 7 years ago

see the example, it's self-explanatory

loicbourgois commented 6 years ago

Samples are now available at https://chartjs.github.io/chartjs-chart-financial/ The source is in master/docs

loicbourgois commented 6 years ago

@benmccann should this issue get closed ?