Add polyfill for Luxon for example to work in IE11

chartjs / chartjs-chart-financial

Chart.js module for charting financial securities

MIT License

721 stars 196 forks source link

Add polyfill for Luxon for example to work in IE11 #64

Closed andrericardo closed 4 years ago

andrericardo commented 4 years ago

[x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

Description

Not sure if IE11 support is desired but this changes the examples to work with IE11. Uses Moment.js for the examples in the docs rather than Luxon.

Related #60

Testing

Working with IE11, ran gulp test, if there are any articles on how to add tests according to what you want can you please let me know?

benmccann commented 4 years ago

I think I'd probably rather not switch the example because Luxon has better support for i18n and timezones, which I care about more for my own use case than IE11 support. I've added some information about date libraries to the README though. Hopefully that will help others who run into this issue

andrericardo commented 4 years ago

Makes sense, would you consider adding the polyfill to example instead? I've managed to get it working with Luxon using the polyfill in IE11, updating the PR.