Updated to Chart.js v3.0.0-beta.3

chartjs / chartjs-chart-financial

Chart.js module for charting financial securities

MIT License

743 stars 199 forks source link

Updated to Chart.js v3.0.0-beta.3 #84

Closed santam85 closed 3 years ago

santam85 commented 3 years ago

Thanks for contributing.

[ V ] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

Description

Updated code to function correctly when using latest chart.js 3.0.0-beta.3

Testing

Tested including the updated library in ng2-charts: https://github.com/valor-software/ng2-charts/pull/1276

benmccann commented 3 years ago

I'm on my phone so can't quite tell, but it looks like you may have changed the tabs indentation to spaces. If so could you please change it back?

santam85 commented 3 years ago

Sorry, not sure what's going on but eslint rules behave differently on my local machine than on travis 🤷‍♂️

santam85 commented 3 years ago

@benmccann would you be open to release this as a beta/with the next tag? It would simplify testing in preparation to ChartJS 3.0 on the other projects and for users.