Modernize Packaging and Infrastructure

etimberg commented 5 years ago

This brings the Smith chart extension up to match other chart.js plugins. This includes the following changes:

Rename from Chart.smith.js to chartjs-chart-smith
CI Release process that matches the main Chart.js repo so that releases can be done entirely from GitHub
Preparations for docs generated using Vuepress and hosted on netlify (like chartjs-plugin-datalabels)
Migrated the build system to rollup
Smith charts work with Chart.js 2.8
Removed tests that relied on the Chart.js mock canvas. These will be replaced with image based tests

simonbrunel commented 5 years ago

@etimberg Great upgrade!

Just a package.json dependency change else the rest of the CI/CD update looks good. I didn't review the code logic since I don't know about this plugin, though it seems that the test coverage decreased a bit.

etimberg commented 5 years ago

Yeah, it's because I removed the bad tests. I'm planning on making a separate change to move to image based tests

chartjs / chartjs-chart-smith

Modernize Packaging and Infrastructure #6