Closed kurkle closed 2 years ago
@kurkle if I may, maybe we could also cleanup the code, where there are some if
statement to check if the scale instance is consistent. These checks shouldn't be needed anymore.
For instance:
What you can do is instead of throwing an error log a warning to the console, something like this:
No scale found with ${Id} for annotation ${annotation}, while this could be intended it is likely you misconfigured something
So you still have some feedback for the users if things don't work. Since I have learned that reading documentation is the last thing a lot of users do.
This reverts commit f2e2481b23a52938fe6992aa618a2488d8e38f92.
As pointed out by @stockiNail there is documentation about behavior with missing scale, thus making the change breaking. Can not have that in 1.2.0.