Enable sub elements - Githubissues

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js

MIT License

607 stars 328 forks source link

Closed kurkle closed 2 years ago

kurkle commented 2 years ago

sub-elems

stockiNail commented 2 years ago

@kurkle what can I say? Cool! I’m having a look and sounds really good! Let me know if I can help

kurkle commented 2 years ago

Not sure if this should be in v2 or if it would be ok to require a certain minor version of chart.js in an minor update.

kurkle commented 2 years ago

Filename	Size	Change
`dist/chartjs-plugin-annotation.esm.js`	12.3 kB	+583 B (+5%)	🔍
`dist/chartjs-plugin-annotation.js`	12.4 kB	+577 B (+5%)	🔍
`dist/chartjs-plugin-annotation.min.js`	8.18 kB	+227 B (+3%)

kurkle commented 2 years ago

Makes sense to clip the sub-elements:

kurkle commented 2 years ago

Not sure if this should be in v2 or if it would be ok to require a certain minor version of chart.js in an minor update.

@etimberg this is the question I requested your review for, but please do a full review too :)