search

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
607 stars 328 forks source link

Remove `point` node from label annotation #558

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

Fix #556

stockiNail commented 2 years ago

I noticed you used the point extensively in #553, are you sure? :)

Well, I thought that the point implementation in the label was done because I'm personally still convinced that the point could be important to be highlighted but, playing with samples, I discovered can a user could want to highlight the point with different shapes or with another annotation, therefore I think to have a point as possible options has got more cons than pro (mainly duplication code and config).

I'm learning step by step... Sorry.

stockiNail commented 2 years ago

I wait to merge for the decision about the other PR about position options, about percentage about number, in order to rebase the other PR going to the shared decision.