search

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
607 stars 328 forks source link

Fix `animations` option type and add missing documentation #560

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

Fixes #559

kurkle commented 2 years ago

Should pay some more attention to the commit messages :)

Screenshot_20211214-190333

stockiNail commented 2 years ago

@kurkle I didn't understand...

kurkle commented 2 years ago

It's the first commit message that gets suggested when merging. You can edit it at that point too.

stockiNail commented 2 years ago

You can edit it at that point too.

Ok.. apologize.. but is it in the form opened when I'm merging? Because I can't see where what you reported is located.

kurkle commented 2 years ago

https://github.com/chartjs/chartjs-plugin-annotation/commits/master

Commit messages create the git history. Pull request description ends up in the release notes and is more important. But good commit messages are important too.

More information for example here: https://www.google.com/amp/s/cbea.ms/git-commit/amp/

stockiNail commented 2 years ago

Now it's clear. My fault is to commit the branch with the "fix [issue]" instead of the real title of the target PR in the project... Sorry. Be patient

kurkle commented 2 years ago

Also don't worry too much about that, I'm not very good with the commit messages either. Just pointing out its something that we should try to improve.

stockiNail commented 2 years ago

Also don't worry too much about that, I'm not very good with the commit messages either. Just pointing out its something that we should try to improve.

Absolutely I'll do!